Re: [PATCH v2] IB/hfi1: Fix sdma.h tx->num_descs off-by-one error (take two)

From: Leon Romanovsky
Date: Sun Feb 04 2024 - 04:40:49 EST



On Thu, 01 Feb 2024 09:10:08 +0100, Daniel Vacek wrote:
> Unfortunately the commit `fd8958efe877` introduced another error
> causing the `descs` array to overflow. This reults in further crashes
> easily reproducible by `sendmsg` system call.
>
> [ 1080.836473] general protection fault, probably for non-canonical address 0x400300015528b00a: 0000 [#1] PREEMPT SMP PTI
> [ 1080.869326] RIP: 0010:hfi1_ipoib_build_ib_tx_headers.constprop.0+0xe1/0x2b0 [hfi1]
> --
> [ 1080.974535] Call Trace:
> [ 1080.976990] <TASK>
> [ 1081.021929] hfi1_ipoib_send_dma_common+0x7a/0x2e0 [hfi1]
> [ 1081.027364] hfi1_ipoib_send_dma_list+0x62/0x270 [hfi1]
> [ 1081.032633] hfi1_ipoib_send+0x112/0x300 [hfi1]
> [ 1081.042001] ipoib_start_xmit+0x2a9/0x2d0 [ib_ipoib]
> [ 1081.046978] dev_hard_start_xmit+0xc4/0x210
> --
> [ 1081.148347] __sys_sendmsg+0x59/0xa0
>
> [...]

Applied, thanks!

[1/1] IB/hfi1: Fix sdma.h tx->num_descs off-by-one error (take two)
https://git.kernel.org/rdma/rdma/c/be39e8dcb411fb

Best regards,
--
Leon Romanovsky <leon@xxxxxxxxxx>