Re: [PATCH net-next v3 4/7] net: dsa: mt7530: move XTAL check to mt7530_setup()

[Arınç ÜNAL]

On 2.02.2024 21:39, Daniel Golle wrote:
> On Fri, Feb 02, 2024 at 09:16:02PM +0300, Arınç ÜNAL wrote:
> > On 2.02.2024 14:48, Russell King (Oracle) wrote:
> > > On Fri, Feb 02, 2024 at 12:19:10PM +0300, Arınç ÜNAL via B4 Relay wrote:
> > > > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > > >
> > > > The crystal frequency concerns the switch core. The frequency should be
> > > > checked when the switch is being set up so the driver can reject the
> > > > unsupported hardware earlier and without requiring port 6 to be used.
> > > >
> > > > Move it to mt7530_setup(). Drop the unnecessary function printing.
> > > >
> > > > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > > > Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> > >
> > > I would prefer this to be earlier in the series, before patch 2 which
> > > moves mt7530_setup_port6() to be called from mac_config(). mac_config()
> > > is supposed to be configuration error-free - in other words, all state
> > > should have been checked before hand.
> >
> > I agree but mt7530_mac_config() is not a void function yet. The
> > mac_port_config member of the mt753x_info structure points to this
> > function. My next patch series gets rid of all useless error returns on the
> > phylink path and change mac_port_config to void. So I don't think working
> > on this patch series further will worth the effort. I'd rather have this
> > version applied as is.
>
> I agree regarding not changing the patch itself, but I also agree
> with Russell regarding the patch ordering. I know it's a 10-minute
> git headache to rebase the patches on top of each other in a different
> order, but you can easily compare the end result being identical to
> what you had before and hence don't need to retest.

This is not about laziness. This is before patch 2:

phylink_mac_ops :: mac_config() -> dsa_port_phylink_mac_config()
-> dsa_switch_ops :: phylink_mac_config() -> mt753x_phylink_mac_config()
   -> mt753x_mac_config()
      -> mt753x_info :: mac_port_config() -> mt7530_mac_config()
         -> mt7530_setup_port5()
   -> mt753x_pad_setup()
      -> mt753x_info :: pad_setup() -> mt7530_pad_clk_setup()

This is after:

phylink_mac_ops :: mac_config() -> dsa_port_phylink_mac_config()
-> dsa_switch_ops :: phylink_mac_config() -> mt753x_phylink_mac_config()
   -> mt753x_mac_config()
      -> mt753x_info :: mac_port_config() -> mt7530_mac_config()
         -> mt7530_setup_port5()
         -> mt7530_setup_port6()

Patch 2 does not move mt7530_setup_port6() to be called from
phylink_mac_ops :: mac_config(), it already is. There is no valid reason to
reorder the patches.

My response to Russell should've stated this instead of focusing on his
second sentence.

pw-bot: under-review

Arınç