RE: [PATCH net] tipc: Check the bearer type before calling tipc_udp_nl_bearer_add()

From: Tung Quang Nguyen
Date: Sun Feb 04 2024 - 10:33:47 EST


> net/tipc/bearer.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 2cde375477e3..878415c43527 100644
>--- a/net/tipc/bearer.c
>+++ b/net/tipc/bearer.c
>@@ -1086,6 +1086,12 @@ int tipc_nl_bearer_add(struct sk_buff *skb, struct genl_info *info)
>
> #ifdef CONFIG_TIPC_MEDIA_UDP
> if (attrs[TIPC_NLA_BEARER_UDP_OPTS]) {
>+ if (b->media->type_id != TIPC_MEDIA_TYPE_UDP) {
>+ rtnl_unlock();
>+ NL_SET_ERR_MSG(info->extack, "UDP option is unsupported");
>+ return -EINVAL;
>+ }
>+
> err = tipc_udp_nl_bearer_add(b,
> attrs[TIPC_NLA_BEARER_UDP_OPTS]);
> if (err) {
>--
>2.41.0
>
Reviewed-by: Tung Nguyen <tung.q.nguyen@xxxxxxxxxxxxxx>