Re: [PATCH v7 20/39] mtd: rawnand: add support for ts72xx

From: andy . shevchenko
Date: Sun Feb 04 2024 - 11:49:57 EST


Thu, Jan 18, 2024 at 11:21:03AM +0300, Nikita Shubin kirjoitti:
> Technologic Systems has it's own nand controller implementation in CPLD.

..

> +err_clean_nand:
> + nand_cleanup(&data->chip);
> +err_handle_put:
> + fwnode_handle_put(child);
> + return err;
> +}
> +
> +static void ts72xx_nand_remove(struct platform_device *pdev)
> +{
> + struct ts72xx_nand_data *data = platform_get_drvdata(pdev);
> + struct nand_chip *chip = &data->chip;
> + int ret;
> +
> + ret = mtd_device_unregister(nand_to_mtd(chip));
> + WARN_ON(ret);
> + nand_cleanup(chip);

Missing fwnode_handle_put()?

> +}


--
With Best Regards,
Andy Shevchenko