Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()

[Andy Shevchenko]

On Sun, Feb 4, 2024 at 8:24 PM Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
> On Sun, Feb 04, 2024 at 06:21:06PM +0200, andy.shevchenko@xxxxxxxxx wrote:
> > Use `ret = dev_err_probe(...);` pattern for all messages in dspi_request_dma()
> > for the sake of uniforming them. While at it, fix indentation issue reported
> > by Vladimir Oltean.
>
> When did I do that? This is v1.

In the original submission (v2 of it to be precise) by Minjie.

..

> >       ret = dmaengine_slave_config(dma->chan_rx, &cfg);
> >       if (ret) {
> > -             dev_err(dev, "can't configure rx dma channel\n");
> > -             ret = -EINVAL;
> > +             ret = dev_err_probe(dev, -EINVAL, "can't configure rx dma channel\n");
>
> Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the "ret"
> from dmaengine_slave_config().

True, but this patch doesn't change the behaviour.

..

> >       if (ret) {
> > -             dev_err(dev, "can't configure tx dma channel\n");
> > -             ret = -EINVAL;
> > +             ret = dev_err_probe(dev, -EINVAL, "can't configure tx dma channel\n");
>
> Same here.

Same answer here.

> >               goto err_slave_config;
> >       }

-- 
With Best Regards,
Andy Shevchenko