Re: [PATCH v13 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

From: Billy Tsai
Date: Mon Feb 05 2024 - 01:59:53 EST


> > From: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> >
> > Add common fan properties bindings to a schema.
> >
> > Bindings for fan controllers can reference the common schema for the
> > fan
> >
> > child nodes:
> >
> > patternProperties:
> > "^fan@[0-2]":
> > type: object
> > $ref: fan-common.yaml#
> > unevaluatedProperties: false
> >
> > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> > Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>

> v12 of this patch got a Reviewed-by: tag from Rob.
> The tag is gone in this version, presumably meaning that there
> was a substantial change.

> I don't normally do this, but I downloaded v12 and v13 and did not
> find a single change. Why did you drop Rob's Reviewed-by: tag ?

Hi Guenter,

The fan DT-binding for version 12 is identical to that of version 13. I
apologize for forgetting to include the 'Reviewed-by' from Rob when
preparing version 13. I will make sure to include it when sending
version 14.

Thanks