Re: [PATCH] ALSA: core: fix unit test dependencies

From: Takashi Iwai
Date: Mon Feb 05 2024 - 02:08:21 EST


On Sun, 04 Feb 2024 22:21:29 +0100,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The Kunit tests fail to link when PCM support is disabled:
>
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
> sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
> sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
> sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
> aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
> sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
> aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
>
> Add the appropriate dependencies.
>
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks, but this was already fixed on for-next branch.


Takashi