Re: [PATCH] mm: hugetlb: fix hugetlb allocation failure when handling freed or in-use hugetlb

From: Baolin Wang
Date: Mon Feb 05 2024 - 03:29:04 EST




On 2/5/2024 2:56 PM, Muchun Song wrote:


On Feb 5, 2024, at 11:54, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> wrote:

When handling the freed hugetlb or in-use hugetlb, we should ignore the
failure of alloc_buddy_hugetlb_folio() to dissolve the old hugetlb successfully,
since we did not use the new allocated hugetlb in this 2 cases.

Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

OK. It is not a fix (I see a fix keyword in subject) but an
optimization for unnecessary-allocation cases. Thanks.

Yes, better to change the subject to 'mm: hugetlb: improve the handling of hugetlb allocation failure for freed or in-use hugetlb'

Andrew, could you help to change the subject line when you apply it? (or you want a new version, please let me know) Thanks.

Reviewed-by: Muchun Song <muchun.song@xxxxxxxxx>

Thanks for reviewing.