Re: [PATCH v2] siox: make siox_bus_type const

From: Uwe Kleine-König
Date: Mon Feb 05 2024 - 04:03:44 EST


Hello Ricardo,

On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ricardo B. Marliere <ricardo@xxxxxxxxxxxx>

I currently have no setup to test this, but compilation is fine, and I
don't expect any surprises.

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks for your patch,
Uwe

PS: b4 gave me:

✗ [PATCH v2] siox: make siox_bus_type const
✗ No key: openpgp/ricardo@xxxxxxxxxxxx
✗ BADSIG: DKIM/marliere.net

when applying your patch. I didn't check the details of the DKIM issue. I
quickly tried to find your pgp key, but failed (wks, kernel-pgpkeys
repo, keyserver).

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature