Re: [PATCH v7 01/39] ARM: ep93xx: Add terminator to gpiod_lookup_table

From: Arnd Bergmann
Date: Mon Feb 05 2024 - 05:03:00 EST


On Mon, Feb 5, 2024, at 09:42, Alexander Sverdlin wrote:
> Hi Arnd and all,
>
> On Fri, 2024-01-19 at 00:52 +0100, Linus Walleij wrote:
>> On Thu, Jan 18, 2024 at 9:22 AM Nikita Shubin via B4 Relay
>> <devnull+nikita.shubin.maquefel.me@xxxxxxxxxx> wrote:
>>
>> > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>> >
>> > Without the terminator, if a con_id is passed to gpio_find() that
>> > does not exist in the lookup table the function will not stop looping
>> > correctly, and eventually cause an oops.
>> >
>> > Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
>> > Reported-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>> > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>>
>> Sorry, my bug...
>> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
>
> Arnd, could you please take this into arm-soc?
> I can send a PR, but this probably makes little sense for one patch?

I'm travelling at the moment, but can take it when I get back.

If you want to be sure it doesn't get lost, please send the
patch (with the Acks) to soc@xxxxxxxxxx and it will end up
in patchwork.

Arnd