Re: [PATCH 6.1 000/219] 6.1.77-rc1 review

[Shreeya Patel]

On Saturday, February 03, 2024 11:53 IST, Daniel Díaz <daniel.diaz@xxxxxxxxxx> wrote:

> Hello!
> 
> On 02/02/24 10:02 p. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.77 release.
> > There are 219 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Mon, 05 Feb 2024 03:51:47 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-61.77-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> We're seeing lots of build problems and warnings with Clang 17 and Clang nightly:
> 
> -----8<-----
>    /builds/linux/drivers/usb/host/xhci.c:1684:37: error: variable 'slot_id' is uninitialized when used here [-Werror,-Wuninitialized]
>     1684 |                         ret = xhci_check_maxpacket(xhci, slot_id,
>          |                                                          ^~~~~~~
>    /builds/linux/drivers/usb/host/xhci.c:1652:22: note: initialize the variable 'slot_id' to silence this warning
>     1652 |         unsigned int slot_id, ep_index;
>          |                             ^
>          |                              = 0
>    1 error generated.
>    make[5]: *** [/builds/linux/scripts/Makefile.build:250: drivers/usb/host/xhci.o] Error 1
> ----->8-----
> 
> Bisection points to:
> 
>    commit 37ef029fe9a5639f12250f75f5d1594c6a11e181
>    Author: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>    Date:   Fri Dec 1 17:06:47 2023 +0200
> 
>        xhci: fix possible null pointer deref during xhci urb enqueue
>        
>        [ Upstream commit e2e2aacf042f52854c92775b7800ba668e0bdfe4 ]
> 
> Reverting the patch makes the build pass.
> 

Hi Daniel and Greg,

Reverting this patch causes some boot failures :-
https://linux.kernelci.org/test/job/stable-rc/branch/linux-6.1.y/kernel/v6.1.76-220-g4f7472958779c/plan/baseline/

Not sure if reverting would be the best way to fix this issue.


Thanks,
Shreeya Patel


> The problem manifests as build error in i386 and x86_64, and as new warnings on Arm, Arm64, and RISC-V.
> 
> Some reproducers:
> 
>    tuxmake --runtime podman --target-arch arm --toolchain clang-17 --kconfig omap2plus_defconfig LLVM=1 LLVM_IAS=1
>    tuxmake --runtime podman --target-arch x86_64 --toolchain clang-17 --kconfig x86_64_defconfig LLVM=1 LLVM_IAS=1
> 
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> 
> 
> Greetings!
> 
> Daniel Díaz
> daniel.diaz@xxxxxxxxxx
> 
>