Re: [PATCH v2 3/4] string: Allow 2-argument strscpy_pad()

From: Andy Shevchenko
Date: Mon Feb 05 2024 - 08:37:45 EST


On Mon, Feb 05, 2024 at 01:48:51PM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 5, 2024 at 1:36 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:

..

> > +#define __strscpy_pad1(dst, src, size) sized_strscpy_pad(dst, src, size)
>
> (dst) etc.

Makes a little sense here. Are you expecting, e.g., dst to be 'a, b' (w/o
quotes where a and b are expressions)?

..

> > +#define strscpy_pad(dst, src, ...) \
> > + CONCATENATE(__strscpy_pad, COUNT_ARGS(__VA_ARGS__))(dst, src, __VA_ARGS__)
>
> Likewise,

Ditto.

--
With Best Regards,
Andy Shevchenko