Re: [PATCH v2 08/23] gpio: sysfs: use gpio_device_find() to iterate over existing devices

[Andy Shevchenko]

On Mon, Feb 05, 2024 at 02:19:10PM +0100, Bartosz Golaszewski wrote:
> On Mon, Feb 5, 2024 at 1:36 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Mon, Feb 05, 2024 at 10:34:03AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > >
> > > With the list of GPIO devices now protected with SRCU we can use
> > > gpio_device_find() to traverse it from sysfs.

..

> > > +static int gpiofind_sysfs_register(struct gpio_chip *gc, void *data)
> > > +{
> > > +     struct gpio_device *gdev = gc->gpiodev;
> > > +     int ret;
> > > +
> > > +     if (gdev->mockdev)
> > > +             return 0;
> > > +
> > > +     ret = gpiochip_sysfs_register(gdev);
> > > +     if (ret)
> > > +             chip_err(gc, "failed to register the sysfs entry: %d\n", ret);
> >
> > > +     return 0;
> >
> > ???

What the point of function to be int if you effectively ignore this by always
returning 0?

> Not sure what the ... and ??? mean? The commit message should have
> read "... traverse it from gpiofind_sysfs_register()" I agree but the
> latter?

I didn't realize this may not be obvious :-(.

> > > +}

-- 
With Best Regards,
Andy Shevchenko