Re: [PATCH v2 06/23] gpio: add SRCU infrastructure to struct gpio_desc

From: Andy Shevchenko
Date: Mon Feb 05 2024 - 08:58:02 EST


On Mon, Feb 05, 2024 at 02:54:08PM +0100, Bartosz Golaszewski wrote:
> On Mon, Feb 5, 2024 at 2:48 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Mon, Feb 05, 2024 at 10:34:01AM +0100, Bartosz Golaszewski wrote:

..

> > > + for (j = 0; j < i; j++)
> > > + cleanup_srcu_struct(&desc->srcu);
> >
> > What does this loop mean?
>
> I open-coded it because I want to store the value of i to go back and
> destroy the SRCU structs on failure.

Where/how is j being used?

> > > + goto err_remove_of_chip;
> > > + }

--
With Best Regards,
Andy Shevchenko