Re: [PATCH v4 03/16] spi: s3c64xx: avoid possible negative array index

From: Peter Griffin
Date: Mon Feb 05 2024 - 10:27:39 EST


On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
>
> The platform id is used as an index into the fifo_lvl_mask array.
> Platforms can come with a negative device ID, PLATFORM_DEVID_NONE (-1),
> thus we risked a negative array index. Catch such cases and fail to
> probe.
>
> Fixes: 2b90807549e5 ("spi: s3c64xx: add device tree support")
> Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---

Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>