Re: [PATCH v2 2/2] iio: adc: ti-ads1298: Add driver

From: Mark Brown
Date: Mon Feb 05 2024 - 10:32:26 EST


On Mon, Feb 05, 2024 at 04:25:19PM +0100, Mike Looijmans wrote:
> On 05-02-2024 14:55, Andy Shevchenko wrote:

> > > > + .cache_type = REGCACHE_RBTREE,

> > Why not MAPPLE TREE?

> Reading the description this driver isn't a good candidate - the map isn't
> sparse and the hardware can do bulk read/write (though the driver doesn't
> use it).

If your driver is a good candidate for rbtree it's a good candidate for
maple tree. There are very few specialist cases where there's an
advantage to sticking with rbtree. The maple cache has no meaningful
overhead compared to rbtree for non-sparse regmaps and will generate
bulk writes just fine.

Attachment: signature.asc
Description: PGP signature