RE: [PATCH] hv: vmbus: make hv_bus const

[Michael Kelley]

From: Ricardo B. Marliere <ricardo@xxxxxxxxxxxx> Sent: Sunday, February 4, 2024 8:38 AM
> 

NIT:  For consistency, we try to use "Drivers: hv: vmbus:" as the prefix on the
Subject line for patches to vmbus_drv.c.

Otherwise,

Reviewed-by: Michael Kelley <mhklinux@xxxxxxxxxxx>

> Now that the driver core can properly handle constant struct bus_type,
> move the hv_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ricardo B. Marliere <ricardo@xxxxxxxxxxxx>
> ---
>  drivers/hv/vmbus_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index edbb38f6956b..c4e6d9f1b510 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -988,7 +988,7 @@ static const struct dev_pm_ops vmbus_pm = {
>  };
> 
>  /* The one and only one */
> -static struct bus_type  hv_bus = {
> +static const struct bus_type  hv_bus = {
>  	.name =		"vmbus",
>  	.match =		vmbus_match,
>  	.shutdown =		vmbus_shutdown,
> 
> ---
> base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70
> change-id: 20240204-bus_cleanup-hv-2ca8a4603ebc
> 
> Best regards,
> --
> Ricardo B. Marliere <ricardo@xxxxxxxxxxxx>
>