Re: [PATCH v1 1/1] ufs: core: fix shift issue in ufshcd_clear_cmd

From: Bart Van Assche
Date: Mon Feb 05 2024 - 12:09:41 EST


On 2/5/24 02:49, alice.chao@xxxxxxxxxxxx wrote:
When task_tag > 32 (in mcq mode), 1U << task_tag will out of bound
^^^^^^^^^^^^^
task_tag >= 32 and sizeof(unsigned int) == 4

for u32 mask. Fix this bug to prevent SHIFT_ISSUE (Bitwise shifts
that are out of bounds for their data type).

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>