Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure

From: Pasha Tatashin
Date: Mon Feb 05 2024 - 13:52:20 EST


On Mon, Feb 5, 2024 at 10:32 AM Robin Murphy <robin.murphy@xxxxxxx> wrote:
>
> Failure handling in iova_cache_get() is a little messy, and we'd like
> to add some more to it, so let's tidy up a bit first. By leaving the
> hotplug handler until last we can take advantage of kmem_cache_destroy()
> being NULL-safe to have a single cleanup label. We can also improve the
> error reporting, noting that kmem_cache_create() already screams if it
> fails, so that one is redundant.
>
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>

Reviewed-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>

Thank you,
Pasha