Re: [PATCH v2 0/4] Add support for QoS configuration

From: Konrad Dybcio
Date: Tue Feb 06 2024 - 04:07:23 EST




On 2/5/24 15:56, Odelu Kukatla wrote:
This series adds QoS support for QNOC type device which can be found on
SC7280 platform. It adds support for programming priority,
priority forward disable and urgency forwarding. This helps in
priortizing the traffic originating from different interconnect masters
at NOC(Network On Chip).

Changes in v2:
- Updated regmap_update to make use GENMASK and FIELD_PREP.
- Removed the regmap structure from qcom_icc_node.
- Made qcom_icc_rpmh_configure_qos() static
- Removed qcom_icc_rpmh_map() API, inlined the code in probe
function.
- Updated declarations to reverse christmas tree fashion.

You ignored some of my previous review comments without a response.

Konrad