Re: [PATCH 2/2] kernel: sched: print errors with %pe for better readability of logs
From: Stanislaw Gruszka
Date: Tue Feb 06 2024 - 04:24:16 EST
On Tue, Feb 06, 2024 at 10:41:20AM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@xxxxxxxxxxx>
>
> instead of printing errros as a number(%ld), it's better to print in string
> format for better readability of logs.
>
> Signed-off-by: Onkarnath <onkarnath.1@xxxxxxxxxxx>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> ---
> kernel/sched/cpufreq_schedutil.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index eece6244f9d2..2c42eaa56fa3 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -671,7 +671,7 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy)
> "sugov:%d",
> cpumask_first(policy->related_cpus));
> if (IS_ERR(thread)) {
> - pr_err("failed to create sugov thread: %ld\n", PTR_ERR(thread));
> + pr_err("failed to create sugov thread: %pe\n", thread);
> return PTR_ERR(thread);
> }
>
> --
> 2.25.1
>
>