RE: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node

[Mukesh Savaliya]

LGTM, Acked.

> -----Original Message-----
> From: Viken Dadhaniya
> Sent: Tuesday, January 30, 2024 10:48 AM
> To: Viken Dadhaniya (QUIC) <quic_vdadhani@xxxxxxxxxxx>;
> andersson@xxxxxxxxxx; konrad.dybcio@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; linux-arm-
> sm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Mukesh Savaliya (QUIC) <quic_msavaliy@xxxxxxxxxxx>; Visweswara
> Tanuku (QUIC) <quic_vtanuku@xxxxxxxxxxx>; Chandana Kishori Chiluveru
> (QUIC) <quic_cchiluve@xxxxxxxxxxx>; krzysztof.kozlowski@xxxxxxxxxx; Viken
> Dadhaniya (QUIC) <quic_vdadhani@xxxxxxxxxxx>
> Subject: RE: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node
> 
> Gentle reminder for review.
> 
> Thanks
> Viken
> 
> > -----Original Message-----
> > From: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
> > Sent: Tuesday, December 12, 2023 8:20 PM
> > To: andersson@xxxxxxxxxx; konrad.dybcio@xxxxxxxxxx;
> > robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> > conor+dt@xxxxxxxxxx; linux-arm- sm@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Vijaya Krishna Nivarthi (Temp) (QUIC) <quic_vnivarth@xxxxxxxxxxx>;
> > Mukesh Savaliya (QUIC) <quic_msavaliy@xxxxxxxxxxx>; Visweswara
> Tanuku
> > (QUIC) <quic_vtanuku@xxxxxxxxxxx>; Chandana Kishori Chiluveru (QUIC)
> > <quic_cchiluve@xxxxxxxxxxx>; krzysztof.kozlowski@xxxxxxxxxx; Viken
> > Dadhaniya
> > (QUIC) <quic_vdadhani@xxxxxxxxxxx>
> > Subject: [V2 RESEND] arm64: dts: qcom: sc7280: add slimbus DT node
> >
> > Populate the DTSI node for slimbus instance to be used by BT FM client.
> >
> > Signed-off-by: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
Acked-by: Mukesh Kumar Savaliya < quic_msavaliy@xxxxxxxxxxx>
> > ---
> > v1 -> v2:
> > - change 0x0 -> 0 to reg property.
> > - reorder the DT property.
> > - change node tag slim_msm to slim.
> > ---
> >  arch/arm64/boot/dts/qcom/sc7280.dtsi | 25
> +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 04bf85b0399a..9fec8743e19a 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -2528,6 +2528,31 @@
> >  			status = "disabled";
> >  		};
> >
> > +		slimbam: dma-controller@3a84000 {
> > +			compatible = "qcom,bam-v1.7.0";
> > +			reg = <0 0x03a84000 0 0x20000>;
> > +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> > +			#dma-cells = <1>;
> > +			qcom,controlled-remotely;
> > +			num-channels  = <31>;
> > +			qcom,ee = <1>;
> > +			qcom,num-ees = <2>;
> > +			iommus = <&apps_smmu 0x1826 0x0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		slim: slim-ngd@3ac0000 {
> > +			compatible = "qcom,slim-ngd-v1.5.0";
> > +			reg = <0 0x03ac0000 0 0x2c000>;
> > +			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> > +			dmas = <&slimbam 3>, <&slimbam 4>;
> > +			dma-names = "rx", "tx";
> > +			iommus = <&apps_smmu 0x1826 0x0>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			status = "disabled";
> > +		};
> > +
> >  		lpass_hm: clock-controller@3c00000 {
> >  			compatible = "qcom,sc7280-lpasshm";
> >  			reg = <0 0x03c00000 0 0x28>;
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> > member of Code Aurora Forum, hosted by The Linux Foundation
>