Re: [PATCH v2 2/2] usb: core: Make default authorization mode configurable

[Geert Uytterhoeven]

Hi Niko,

On Fri, Jan 5, 2024 at 12:51 PM <niko.mauno@xxxxxxxxxxx> wrote:
> From: Niko Mauno <niko.mauno@xxxxxxxxxxx>
>
> Make the default USB device authorization mode configurable at build
> time. This is useful for systems that require a mode that is stricter
> than the standard setting, as it avoids relying on the kernel command
> line being properly set.
>
> Signed-off-by: Niko Mauno <niko.mauno@xxxxxxxxxxx>

Thanks for your patch, which is now commit bec7e43b162c5879
("usb: core: Make default authorization mode configurable")
in usb/usb-next.

> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -116,3 +116,20 @@ config USB_AUTOSUSPEND_DELAY
>           The default value Linux has always had is 2 seconds.  Change
>           this value if you want a different delay and cannot modify
>           the command line or module parameter.
> +
> +config USB_DEFAULT_AUTHORIZATION_MODE
> +       int "Default authorization mode for USB devices"
> +       range 0 2
> +       default 1
> +       depends on USB
> +       help
> +         Select the default USB device authorization mode. Can be overridden
> +         with usbcore.authorized_default command line or module parameter.
> +
> +         The available values have the following meanings:
> +               0 is unauthorized for all devices
> +               1 is authorized for all devices (default)
> +               2 is authorized for internal devices
> +
> +         If the default value is too permissive but you are unsure which mode
> +         to use, say 2.

I'm sorry, but I don't have any clue about what to answer to this question.
Usually, you are (or are not) authorized to do _something_, but the
/something/ is not mentioned at all here.
Can you please make this a bit more clear?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds