Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

[frut3k7]

On Tue, Feb 6, 2024 at 5:19 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 06/02/2024 17:11, frut3k7 wrote:
> > On Tue, Feb 6, 2024 at 8:44 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 05/02/2024 20:18, Paweł Owoc wrote:
> >>> Add Qualcomm QCA4024 to trivial devices.
> >>>
> >>> Signed-off-by: Paweł Owoc <frut3k7@xxxxxxxxx>
> >>> ---
> >>>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> index 79dcd92c4a43..50efbdf2a735 100644
> >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> @@ -309,6 +309,8 @@ properties:
> >>>            - plx,pex8648
> >>>              # Pulsedlight LIDAR range-finding sensor
> >>>            - pulsedlight,lidar-lite-v2
> >>> +            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
> >>> +          - qca,spidev
> >>
> >> There is no such hardware as spidev and you even mentioned it is called
> >> QCA4024, not spidev. Please don't use that name but a real name.
> >>
> > The compatibility will be changed to "qca4024" and a new patch version
> > will be prepared.
>
> That would be ok except:
>
> >
> >> Also, I have doubts that Bluetooth is a trivial device. Such devices
> >> need supplies, have reset/powerdown GPIOs.
>
> this is not resolved. Bluetooth chips are not trivial devices. This one
> particular exposes several interfaces to the host, needs a clock and
> power supply.
>
Device is used over QUP4 SPI controller inside of IPQ8074:
https://lore.kernel.org/all/20231123121324.1046164-1-robimarko@xxxxxxxxx/
I'm not sure if these pin settings should be upstreamed as they are
specific to this platform:
https://github.com/openwrt/openwrt/pull/14051/files#diff-ed3fbf0226fbdc76c9c160f2f2b9e988120df472480b9861abe7a46796558115R81-R111

> Best regards,
> Krzysztof
>