Re: [PATCH] pidfd: exit: kill the no longer used thread_group_exited()

[Tycho Andersen]

On Mon, Feb 05, 2024 at 06:43:47PM +0100, Oleg Nesterov wrote:
> It was used by pidfd_poll() but now it has no callers.
> 
> If it finally finds a modular user we can revert this change, but note
> that the comment above this helper and the changelog in 38fd525a4c61
> ("exit: Factor thread_group_exited out of pidfd_poll") are not accurate,
> thread_group_exited() won't return true if all other threads have passed
> exit_notify() and are zombies, it returns true only when all other threads
> are completely gone. Not to mention that it can only work if the task
> identified by @pid is a thread-group leader.
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Reviewed-by: Tycho Andersen <tandersen@xxxxxxxxxxx>