Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs

From: Chris Packham
Date: Tue Feb 06 2024 - 16:41:26 EST



On 7/02/24 10:12, Alexandre Belloni wrote:
> On 06/02/2024 20:19:20+0000, Chris Packham wrote:
>> That is an incredibly good point. The max31335 binding covers one specific chip. This binding covers more and with that there are a few more properties that the max31335 on it's own doesn't have (e.g. the clock consumer, the ability to have different i2c addresses). Binding wise I could probably roll all of the max31335 into this max313xx binding.
>>
>> Driver wise things are a bit trickier. I've only got access to one of
>> the variants so I am hoping to leverage the work Ibrahim had already
>> done. I could attempt to incorporate max31335 support into the
>> max313xx driver but I wouldn't really be able to test it properly and
>> there is a reasonably high chance of regressing something.
> But I won't take a separate driver. Everything would be better if Analog
> was sharing the datasheets...

The datasheets are pretty accessible so I'd give Analog a pass on that
(they're certainly better than some vendors). I'll include some links on
the next update.

I'll attempt to roll the max31335 into the max313xx driver.