Re: [PATCH 17/17] vfio/pci: Remove duplicate interrupt management flow

From: Reinette Chatre
Date: Tue Feb 06 2024 - 16:47:13 EST


Hi Alex,

On 2/5/2024 2:35 PM, Alex Williamson wrote:
> On Thu, 1 Feb 2024 20:57:11 -0800
> Reinette Chatre <reinette.chatre@xxxxxxxxx> wrote:

..

>> @@ -799,11 +765,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev,
>> if (!ctx || !ctx->trigger)
>> continue;
>> if (flags & VFIO_IRQ_SET_DATA_NONE) {
>> - eventfd_signal(ctx->trigger);
>> + intr_ops[index].send_eventfd(vdev, ctx);
>> } else if (flags & VFIO_IRQ_SET_DATA_BOOL) {
>> uint8_t *bools = data;
>
> Nit, an opportunity to add the missing new line between variable
> declaration and code here. Thanks,

Will do. Thank you.

Reinette