Re: [PATCH 2/2 v3] cxl/region: Use cond_guard() in show_targetN()

[kernel test robot]

Hi Fabio,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.8-rc3 next-20240206]
[cannot apply to cxl/next cxl/pending]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Fabio-M-De-Francesco/cleanup-Add-cond_guard-to-conditional-guards/20240206-203110
base:   linus/master
patch link:    https://lore.kernel.org/r/20240206121301.7225-3-fabio.maria.de.francesco%40linux.intel.com
patch subject: [PATCH 2/2 v3] cxl/region: Use cond_guard() in show_targetN()
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240207/202402070919.0zuYCxMS-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240207/202402070919.0zuYCxMS-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402070919.0zuYCxMS-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/cxl/core/region.c: In function 'show_targetN':
>> drivers/cxl/core/region.c:670:70: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     670 |         cond_guard(rwsem_read_intr, return -EINTR, &cxl_region_rwsem);
         |                                                                      ^


vim +/else +670 drivers/cxl/core/region.c

   664	
   665	static size_t show_targetN(struct cxl_region *cxlr, char *buf, int pos)
   666	{
   667		struct cxl_region_params *p = &cxlr->params;
   668		struct cxl_endpoint_decoder *cxled;
   669	
 > 670		cond_guard(rwsem_read_intr, return -EINTR, &cxl_region_rwsem);
   671	
   672		if (pos >= p->interleave_ways) {
   673			dev_dbg(&cxlr->dev, "position %d out of range %d\n", pos,
   674				p->interleave_ways);
   675			return -ENXIO;
   676		}
   677	
   678		cxled = p->targets[pos];
   679		if (!cxled)
   680			return sysfs_emit(buf, "\n");
   681	
   682		return sysfs_emit(buf, "%s\n", dev_name(&cxled->cxld.dev));
   683	}
   684	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki