Re: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12: warning: stack frame size (3368) exceeds limit (2048) in 'dml_core_mode_support'

[Yujie Liu]

On Tue, Feb 06, 2024 at 04:18:55PM +0000, Pillai, Aurabindo wrote:
> [AMD Official Use Only - General]
> 
> Hi,
> 
> I tried with LLVM16 (from Manjaro) and couldnt repro the issue on both mainline and amd-staging-drm-next. Could someone share the config used for this build ?

Hi,

There is a "reproduce" link in the original report. Hope it would be
helpful:

reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM1-lkp@xxxxxxxxx/reproduce)

For a quick check, please kindly try the following steps to reproduce
the issue:

$ git checkout v6.8-rc3
$ wget https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM1-lkp@xxxxxxxxx/config -O .config
$ make W=1 LLVM=1 ARCH=x86_64 olddefconfig
$ make -j$(nproc) W=1 LLVM=1 ARCH=x86_64 drivers/gpu/drm/amd/amdgpu/
..
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6710:12: warning: stack frame size (3368) exceeds limit (3072) in 'dml_core_mode_support' [-Wframe-larger-than]
dml_bool_t dml_core_mode_support(struct display_mode_lib_st *mode_lib)
           ^

Best Regards,
Yujie

> 
> --
> 
> Regards,
> Jay
> ________________________________
> From: Zhuo, Lillian <Qingqing.Zhuo@xxxxxxx>
> Sent: Tuesday, February 6, 2024 11:06 AM
> To: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>
> Cc: kernel test robot <lkp@xxxxxxxxx>; oe-kbuild-all@xxxxxxxxxxxxxxx <oe-kbuild-all@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>
> Subject: RE: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12: warning: stack frame size (3368) exceeds limit (2048) in 'dml_core_mode_support'
> 
> [AMD Official Use Only - General]
> 
> + Jay, who is looking into the issue
> 
> -----Original Message-----
> From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> Sent: Tuesday, February 6, 2024 8:20 AM
> To: Zhuo, Lillian <Qingqing.Zhuo@xxxxxxx>
> Cc: kernel test robot <lkp@xxxxxxxxx>; oe-kbuild-all@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>
> Subject: Re: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12: warning: stack frame size (3368) exceeds limit (2048) in 'dml_core_mode_support'
> 
> From: Kernel Test Robot <lkp@xxxxxxxxx>
> Date: Mon, 20 Nov 2023 10:01:21 +0800
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   037266a5f7239ead1530266f7d7af153d2a867fa
> > commit: 7966f319c66d9468623c6a6a017ecbc0dd79be75 drm/amd/display: Introduce DML2
> > date:   6 weeks ago
> > config: x86_64-randconfig-121-20231119
> > (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM
> > 1-lkp@xxxxxxxxx/config)
> > compiler: clang version 16.0.4
> > (https://github.com/llvm/llvm-project.git
> > ae42196bc493ffe877a7e3dff8be32035dea4d07)
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM
> > 1-lkp@xxxxxxxxx/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new
> > version of the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes:
> > | https://lore.kernel.org/oe-kbuild-all/202311200955.pmjdQEM1-lkp@inte
> > | l.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >    warning: unknown warning option '-Wstringop-truncation'; did you mean '-Wstring-concatenation'? [-Wunknown-warning-option]
> >    warning: unknown warning option '-Wpacked-not-aligned'; did you
> > mean '-Wpacked-non-pod'? [-Wunknown-warning-option]
> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:61
> >>> 93:12: warning: stack frame size (3368) exceeds limit (2048) in
> >>> 'dml_core_mode_support' [-Wframe-larger-than]
> >    dml_bool_t dml_core_mode_support(struct display_mode_lib_st
> > *mode_lib)
> 
> Ping? This still happens on the latest RC and linux-next on LLVM 19 at least (-O2) and breaks CONFIG_WERROR builds.
> 
> >               ^
> >    2183/3368 (64.82%) spills, 1185/3368 (35.18%) variables
> >    drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8241:6: warning: stack frame size (2232) exceeds limit (2048) in 'dml_core_mode_programming' [-Wframe-larger-than]
> >    void dml_core_mode_programming(struct display_mode_lib_st *mode_lib, const struct dml_clk_cfg_st *clk_cfg)
> >         ^
> >    1441/2232 (64.56%) spills, 791/2232 (35.44%) variables
> >    4 warnings generated.
> Thanks,
> Olek