Re: [PATCH 11/18] mfd: rohm: convert to use maple tree register cache

[Matti Vaittinen]

On 2/6/24 09:13, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Bo Liu <liubo03@xxxxxxxxxx>

Acked-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

> ---
>   drivers/mfd/rohm-bd71828.c | 4 ++--
>   drivers/mfd/rohm-bd718x7.c | 2 +-
>   drivers/mfd/rohm-bd9576.c  | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c
> index 594718f7e8e1..2f3826c7eef4 100644
> --- a/drivers/mfd/rohm-bd71828.c
> +++ b/drivers/mfd/rohm-bd71828.c
> @@ -197,7 +197,7 @@ static const struct regmap_config bd71815_regmap = {
>   	.val_bits = 8,
>   	.volatile_table = &bd71815_volatile_regs,
>   	.max_register = BD71815_MAX_REGISTER - 1,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   };
>   
>   static const struct regmap_config bd71828_regmap = {
> @@ -205,7 +205,7 @@ static const struct regmap_config bd71828_regmap = {
>   	.val_bits = 8,
>   	.volatile_table = &bd71828_volatile_regs,
>   	.max_register = BD71828_MAX_REGISTER,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   };
>   
>   /*
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index 4798bdf27afb..7755a4c073bf 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -87,7 +87,7 @@ static const struct regmap_config bd718xx_regmap_config = {
>   	.val_bits = 8,
>   	.volatile_table = &volatile_regs,
>   	.max_register = BD718XX_MAX_REGISTER - 1,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   };
>   
>   static int bd718xx_init_press_duration(struct regmap *regmap,
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index bceac7016740..3a9f61961721 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -62,7 +62,7 @@ static struct regmap_config bd957x_regmap = {
>   	.val_bits = 8,
>   	.volatile_table = &volatile_regs,
>   	.max_register = BD957X_MAX_REGISTER,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   };
>   
>   static struct regmap_irq bd9576_irqs[] = {

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~