Re: [PATCH v12 04/20] KVM: pfncache: add a mark-dirty helper

[Paul Durrant]

On 07/02/2024 03:20, Sean Christopherson wrote:
> On Mon, Jan 15, 2024, Paul Durrant wrote:
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index 7e7fd25b09b3..f3bb9e0a81fe 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -1399,6 +1399,17 @@ int kvm_gpc_refresh(struct gfn_to_pfn_cache *gpc, unsigned long len);
> >    */
> >   void kvm_gpc_deactivate(struct gfn_to_pfn_cache *gpc);
> >   
> > +/**
> > + * kvm_gpc_mark_dirty - mark a cached page as dirty.
> > + *
> > + * @gpc:	   struct gfn_to_pfn_cache object.
> > + */
> > +static inline void kvm_gpc_mark_dirty(struct gfn_to_pfn_cache *gpc)
>
> Any objection to kvm_gpc_mark_dirty_in_slot()?  I want to make it clear this only
> marks the gfn dirty in the memslot, i.e. that it doesn't mark the underlying page
> as dirty.

Ok, that sounds fair.

  Paul