RE: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

[Ding, Shenghao]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, February 6, 2024 9:53 PM
> To: Ding, Shenghao <shenghao-ding@xxxxxx>; broonie@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; linux-sound@xxxxxxxxxxxxxxx;
> liam.r.girdwood@xxxxxxxxx; lgirdwood@xxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Lu, Kevin <kevin-lu@xxxxxx>; Xu, Baojun <baojun.xu@xxxxxx>; P O, Vijeth
> <v-po@xxxxxx>; Navada Kanyana, Mukund <navada@xxxxxx>;
> perex@xxxxxxxx; McPherson, Jeff <j-mcpherson@xxxxxx>; pierre-
> louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; Chawla, Mohit
> <mohit.chawla@xxxxxx>; soyer@xxxxxx; Huang, Jonathan
> <jkhuang3@xxxxxx>; tiwai@xxxxxxx; Djuandi, Peter <pdjuandi@xxxxxx>;
> Agrawal, Manisha <manisha.agrawal@xxxxxx>; Hari, Raj <s-hari@xxxxxx>;
> Yashar, Avi <aviel@xxxxxx>; Nagalla, Hari <hnagalla@xxxxxx>; Bajjuri,
> Praneeth <praneeth@xxxxxx>
> Subject: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add
> initial DT binding
> 
> On 03/02/2024 04: 05, Shenghao Ding wrote: > + > + ti,tad5212: Low-power
> stereo audio DAC with 120-dB dynamic range. > + oneOf: > + - items: > + -
> enum: > + - ti,adc3120 > + - ti,adc5120 > + - ti,pcm3120 > + - ti,pcm5120
> ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas
> Instruments.
> Do not click links or open attachments unless you recognize the source of
> this email and know the content is safe.
> 
> ZjQcmQRYFpfptBannerEnd
> On 03/02/2024 04:05, Shenghao Ding wrote:
> > +
> > +      ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range.
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - ti,adc3120
> > +              - ti,adc5120
> > +              - ti,pcm3120
> > +              - ti,pcm5120
> > +              - ti,pcm6120
> > +          - const: ti,adc6120
> > +      - items:
> > +          - enum:
> > +              - ti,pcm6260
> > +              - ti,pcm6140
> > +              - ti,pcm3140
> > +              - ti,pcm5140
> > +          - const: ti,pcm6240
> > +      - items:
> > +          - const: ti,dix4192
> > +          - const: ti,pcm6240
> 
> Why dix4192 is not part of previous enum?

dix4192 is not traditional ADC or DAC, but an Integrated Digital Audio Interface 
Receiver and Transmitter, like an audio bridge to connect different digital audio 
protocol, compatible with the AES3, S/PDIF, IEC 60958, and EIAJ CP-1201 
interface standards, Left-Justified, Right-Justified, and Philips I2S™ Data Formats. 
So keep it alone for professional purpose. 

> 
> > +      - items:
> > +          - const: ti,adc6120
> > +          - const: ti,pcmd512x
> > +      - items:
> > +          - const: ti,pcm1690
> > +          - const: ti,pcm9211
> > +      - items:
> > +          - enum:
> > +              - ti,pcmd3180
> > +          - const: ti,pcmd3140
> > +      - items:
> > +          - enum:
> > +              - ti,taa5412
> > +          - const: ti,taa5212
> > +      - items:
> > +          - enum:
> > +              - ti,tad5412
> > +          - const: ti,tad5212
> > +      - enum:
> > +          - ti,pcm6240
> > +          - ti,pcmd3140
> > +          - ti,taa5212
> > +          - ti,tad5212
> > +          - ti,pcmd3180
> 
> This one is duplicated.
accept
> 
> > +
> 
> 
> Best regards,
> Krzysztof