Re: [PATCH] net/mlx5: remove redundant assignment to variable object_range

From: Simon Horman
Date: Wed Feb 07 2024 - 04:50:04 EST


On Tue, Feb 06, 2024 at 04:58:15PM +0000, Colin Ian King wrote:
> The variable object_range to log_header_modify_argument_granularity
> is being assigned a value that is never read, the following statement
> assigns object_range to the max of log_header_modify_argument_granularity
> and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial
> assignment is redundant. Remove it.
>
> Cleans up clang-scan build warning:
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning:
> Value stored to 'object_range' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Thanks Colin,

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>