Re: [PATCH] KVM: selftests: Fix a semaphore imbalance in the dirty ring logging test

From: Eric Auger
Date: Wed Feb 07 2024 - 07:56:22 EST


Hi Sean,

On 2/6/24 22:36, Sean Christopherson wrote:
> On Fri, 02 Feb 2024 15:18:31 -0800, Sean Christopherson wrote:
>> When finishing the final iteration of dirty_log_test testcase, set
>> host_quit _before_ the final "continue" so that the vCPU worker doesn't
>> run an extra iteration, and delete the hack-a-fix of an extra "continue"
>> from the dirty ring testcase. This fixes a bug where the extra post to
>> sem_vcpu_cont may not be consumed, which results in failures in subsequent
>> runs of the testcases. The bug likely was missed during development as
>> x86 supports only a single "guest mode", i.e. there aren't any subsequent
>> testcases after the dirty ring test, because for_each_guest_mode() only
>> runs a single iteration.
>>
>> [...]
>
> Applied to kvm-x86 selftests, thanks!
Do you plan to send this branch to Paolo for v6.8?

Thanks

Eric
>
> [1/1] KVM: selftests: Fix a semaphore imbalance in the dirty ring logging test
> https://github.com/kvm-x86/linux/commit/ba58f873cdee

>
> --
> https://github.com/kvm-x86/linux/tree/next
>