RE: [PATCH][next] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()

[Yuan, Perry]

[AMD Official Use Only - General]

 Hi Tor,

> -----Original Message-----
> From: Tor Vic <torvic9@xxxxxxxxxxx>
> Sent: Wednesday, February 7, 2024 9:09 PM
> To: Huang, Ray <Ray.Huang@xxxxxxx>; Yuan, Perry
> <Perry.Yuan@xxxxxxx>; rafael@xxxxxxxxxx
> Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; linux-
> pm@xxxxxxxxxxxxxxx; Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> Subject: [PATCH][next] cpufreq: amd-pstate: Fix min_perf assignment in
> amd_pstate_adjust_perf()
>
> In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set to
> 'highest_perf' instead of 'lowest_perf'.
>
> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD
> P-State")
> Reported-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> Signed-off-by: Tor Vic <torvic9@xxxxxxxxxxx>
> ---
> IIRC, this was first reported by Oleksandr, hence the 'Reported-by' tag.
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 08e112444c27..aa5e57e27d2b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>       if (target_perf < capacity)
>               des_perf = DIV_ROUND_UP(cap_perf * target_perf,
> capacity);
>
> -     min_perf = READ_ONCE(cpudata->highest_perf);
> +     min_perf = READ_ONCE(cpudata->lowest_perf);
>       if (_min_perf < capacity)
>               min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
>
> --
> 2.43.0

Thanks for the fix!

Reviewed-by: Perry Yuan <Perry.Yuan@xxxxxxx>