Re: [PATCH 2/2] regulator: rpmh-regulator: Add RPMH regulator support for Nord

[Shawn Guo]

On Mon, Apr 20, 2026 at 11:21:23AM +0200, Konrad Dybcio wrote:
> On 4/20/26 9:26 AM, Shawn Guo wrote:
> > From: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > 
> > Add support for PMAU0102 PMIC voltage regulators which are present on
> > Nord boards.
> > 
> > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/regulator/qcom-rpmh-regulator.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> > index 6e4cb2871fca..9545300d7b03 100644
> > --- a/drivers/regulator/qcom-rpmh-regulator.c
> > +++ b/drivers/regulator/qcom-rpmh-regulator.c
> > @@ -1100,6 +1100,21 @@ static const struct rpmh_vreg_init_data pm8998_vreg_data[] = {
> >  	{}
> >  };
> >  
> > +static const struct rpmh_vreg_init_data pmau0102_vreg_data[] = {
> > +	RPMH_VREG("smps1",  SMPS, 1,  &pmic5_ftsmps527,  "vdd-s1"),
> > +	RPMH_VREG("smps2",  SMPS, 2,  &pmic5_ftsmps527,  "vdd-s2"),
> > +	RPMH_VREG("smps3",  SMPS, 3,  &pmic5_ftsmps527,  "vdd-s3"),
> > +	RPMH_VREG("smps4",  SMPS, 4,  &pmic5_ftsmps527,  "vdd-s4"),
> > +	RPMH_VREG("smps5",  SMPS, 5,  &pmic5_ftsmps527,  "vdd-s5"),
> > +	RPMH_VREG("smps6",  SMPS, 6,  &pmic5_ftsmps527,  "vdd-s6"),
> > +	RPMH_VREG("smps7",  SMPS, 7,  &pmic5_ftsmps527,  "vdd-s7"),
> > +	RPMH_VREG("smps8",  SMPS, 8,  &pmic5_ftsmps527,  "vdd-s8"),
> > +	RPMH_VREG("ldo1",   LDO,  1,  &pmic5_nldo515,    NULL),
> > +	RPMH_VREG("ldo2",   LDO,  2,  &pmic5_nldo515,    NULL),
> > +	RPMH_VREG("ldo3",   LDO,  3,  &pmic5_pldo515_mv, NULL),
> 
> Any reason for the NULL supplies?

We thought it's fine to not model LDO supplies, as they may not always
follow PMIC.  But that might be even a good reason for modeling, so that
we can have a better DT description for the supplies.  I will change it
to:

	RPMH_VREG("ldo1",   LDO,  1,  &pmic5_nldo515,    "vdd-l1"),
	RPMH_VREG("ldo2",   LDO,  2,  &pmic5_nldo515,    "vdd-l2"),
	RPMH_VREG("ldo3",   LDO,  3,  &pmic5_pldo515_mv, "vdd-l3"),

Thanks for asking!

Shawn