Re: [PATCH v2 5/7] nvmem: release the write-protect pin

From: Srinivas Kandagatla
Date: Tue Feb 18 2020 - 07:24:36 EST




On 18/02/2020 09:42, Bartosz Golaszewski wrote:
@@ -428,6 +429,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
device_del(&nvmem->dev);
err_put_device:
put_device(&nvmem->dev);
+ gpiod_put(nvmem->wp_gpio);
err_ida_remove:
ida_simple_remove(&nvmem_ida, nvmem->id);
err_free_nvmem:

This is also redundant as explained in my previous comments about release()

--srini


--