Re: [PATCH v2 4/8] bootconfig: Remove unneeded checksum

From: Steven Rostedt
Date: Thu Feb 20 2020 - 12:14:36 EST


On Thu, 20 Feb 2020 21:19:02 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Remove checksum of bootconfig because we already use a magic
> word to identify bootconfig. This checksum was used for
> checking whether there is a bootconfig at the end of initrd
> or not. Since we have a bootconfig magic word to identify
> the bootconfig data, we do not this checksum anymore.
>
> Thus the block image of the initrd file with bootconfig is
> as follows.
>
> [initrd][bootconfig][size(u32)][#BOOTCONFIG\n]
>
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> ---
>

Hmm, I think the checksum is still good to have, in case of a corrupted
file. Does it hurt to keep it?

-- Steve