Re: [PATCH v2 4/8] bootconfig: Remove unneeded checksum

[Masami Hiramatsu]

On Thu, 20 Feb 2020 12:14:31 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 20 Feb 2020 21:19:02 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> 
> > Remove checksum of bootconfig because we already use a magic
> > word to identify bootconfig. This checksum was used for
> > checking whether there is a bootconfig at the end of initrd
> > or not. Since we have a bootconfig magic word to identify
> > the bootconfig data, we do not this checksum anymore.
> > 
> > Thus the block image of the initrd file with bootconfig is
> > as follows.
> > 
> > [initrd][bootconfig][size(u32)][#BOOTCONFIG\n]
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > ---
> >
> 
> Hmm, I think the checksum is still good to have, in case of a corrupted
> file. Does it hurt to keep it?

No problem. We can drop this patch.
I thought this check was a bit redundant since (originally) this was
introduced to identify the bootconfig.

Thank you,

> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>