Re: [Patch v10 1/9] sched/pelt: Add support to track thermal pressure

[Thara Gopinath]

On 2/21/20 7:59 PM, Randy Dunlap wrote:
> On 2/21/20 4:52 PM, Thara Gopinath wrote:
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 2a25c769eaaa..8d56902efa70 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -464,6 +464,10 @@ config HAVE_SCHED_AVG_IRQ
> >   	depends on IRQ_TIME_ACCOUNTING || PARAVIRT_TIME_ACCOUNTING
> >   	depends on SMP
> >   
> > +config HAVE_SCHED_THERMAL_PRESSURE
> > +	bool "Enable periodic averaging of thermal pressure"
>
> This prompt string makes this symbol user-configurable, but
> I don't think that's what you want here.

Hi Randy,
Thank you for the review.
Actually I thought being user-configurable is a good idea as it will 
allow users to easily enable it and see if the benefits their systems. 
(I used menuconfig while developing, to enable it).
Do you see a reason why this should not be so?

> > +	depends on SMP
> > +
> >   config BSD_PROCESS_ACCT
> >   	bool "BSD Process Accounting"
> >   	depends on MULTIUSER

--
Warm Regards
Thara