Re: [Patch v10 1/9] sched/pelt: Add support to track thermal pressure

[Randy Dunlap]

On 2/22/20 10:27 AM, Thara Gopinath wrote:
> 
> 
> On 2/21/20 7:59 PM, Randy Dunlap wrote:
>> On 2/21/20 4:52 PM, Thara Gopinath wrote:
>>> diff --git a/init/Kconfig b/init/Kconfig
>>> index 2a25c769eaaa..8d56902efa70 100644
>>> --- a/init/Kconfig
>>> +++ b/init/Kconfig
>>> @@ -464,6 +464,10 @@ config HAVE_SCHED_AVG_IRQ
>>> ÂÂÂÂÂ depends on IRQ_TIME_ACCOUNTING || PARAVIRT_TIME_ACCOUNTING
>>> ÂÂÂÂÂ depends on SMP
>>> Â +config HAVE_SCHED_THERMAL_PRESSURE
>>> +ÂÂÂ bool "Enable periodic averaging of thermal pressure"
>>
>> This prompt string makes this symbol user-configurable, but
>> I don't think that's what you want here.
> 
> Hi Randy,
> Thank you for the review.
> Actually I thought being user-configurable is a good idea as it will allow users to easily enable it and see if the benefits their systems. (I used menuconfig while developing, to enable it).
> Do you see a reason why this should not be so?
> 
>>
>>> +ÂÂÂ depends on SMP
>>> +
>>> Â config BSD_PROCESS_ACCT
>>> ÂÂÂÂÂ bool "BSD Process Accounting"
>>> ÂÂÂÂÂ depends on MULTIUSER

Hi Thara,
Is there some other way that HAVE_SCHED_THERMAL_PRESSURE can become
set/enabled?  for example, is it selected by any other options?

The Kconfig symbols that begin with HAVE_ are usually something that
are platform-specific and are usually set (selected) by other options,
or they are "default y".

In init/Kconfig, I see 15 other HAVE_ Kconfig symbols,
and none of them have user prompt strings.  They are either selected
elsewhere or set inside their Kconfig block.

Maybe you just want to rename the Kconfig symbol so that it does not
being with HAVE_.


-- 
~Randy