Re: [PATCH v4 16/18] MIPS: mobileye: eyeq5: add reset properties to UARTs

From: Krzysztof Kozlowski
Date: Thu Feb 01 2024 - 04:14:24 EST


On 31/01/2024 17:26, Théo Lebrun wrote:
> UART nodes have been added to the devicetree by the initial platform
> support patch series. Add reset properties now that the reset node is
> declared.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> ---
> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> index 06e941b0ce10..ece71cafb6ee 100644
> --- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> +++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> @@ -78,6 +78,7 @@ uart0: serial@800000 {
> interrupts = <GIC_SHARED 6 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&uart_clk>, <&occ_periph>;
> clock-names = "uartclk", "apb_pclk";
> + resets = <&reset 0 10>;

You touch the same file. Squash the patch with previous one. It's the
same logical change to add reset to entire SoC. You don't add half of
reset, right?

Best regards,
Krzysztof