Re: [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on
From: Krzysztof Kozlowski
Date: Thu Feb 01 2024 - 04:58:37 EST
On 30/01/2024 10:36, André Draszik wrote:
> This pclk clock is required any time we access the pinctrl registers of
> this block.
>
> Since pinctrl-samsung doesn't support a clock at the moment, we just
> keep the kernel from disabling it at boot, until we have an update for
> pinctrl-samsung to handle this required clock, at which point we'll be
> able to drop the flag again.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
Dropped fixes tag. The driver looks correct, it's pinctrl issue.
I really dislike how these patches are inter-mixed with DTS. Makes
applying difficult and confuses about dependencies.
I assume there are no dependencies here.
I am repeating this and repeating, but in future I will just reject the
patches:
Your DTS and driver changes cannot depend on each other for new feature
submissions.
Best regards,
Krzysztof