Re: [PATCH v7 1/5] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

From: Rob Herring
Date: Fri Feb 02 2024 - 14:17:24 EST



On Fri, 02 Feb 2024 11:55:34 -0600, Hari Nagalla wrote:
> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> The remote processor's life cycle management and IPC mechanisms are
> similar across the R5F and M4F cores from remote processor driver
> point of view. However, there are subtle differences in image loading
> and starting the M4F subsystems.
>
> The YAML binding document provides the various node properties to be
> configured by the consumers of the M4F subsystem.
>
> Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> Signed-off-by: Hari Nagalla <hnagalla@xxxxxx>
> ---
> Changes since v1:
> - Spelling corrections
> - Corrected to pass DT checks
>
> Changes since v2:
> - Missed spelling correction to commit message
>
> Changes since v3:
> - Removed unnecessary descriptions and used generic memory region names
> - Made mboxes and memory-region optional
> - Removed unrelated items from examples
>
> Changes since v4:
> - Rebased to the latest kernel-next tree
> - Added optional sram memory region for m4f device node
>
> Changes since v5:
> - None
>
> Changes since v6:
> - Removed blank line, fixed type for firm-ware property and binding check
> errors.
>
> link to v6:
> https://lore.kernel.org/all/20230913111644.29889-2-hnagalla@xxxxxx/
>
> .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 138 ++++++++++++++++++
> 1 file changed, 138 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240202175538.1705-2-hnagalla@xxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.