Re: [PATCH] tracing: use ring_buffer_record_is_set_on() in tracer_tracing_is_on()

[Steven Rostedt]

On Mon,  5 Feb 2024 07:53:40 +0100
Sven Schnelle <svens@xxxxxxxxxxxxx> wrote:

> tracer_tracing_is_on() checks whether record_disabled is not zero. This
> checks both the record_disabled counter and the RB_BUFFER_OFF flag.
> Reading the source it looks like this function should only check for
> the RB_BUFFER_OFF flag. Therefore use ring_buffer_record_is_set_on().
> This fixes spurious fails in the 'test for function traceon/off triggers'
> test from the ftrace testsuite when the system is under load.
> 

I've seen these spurious failures too, but haven't looked deeper into
it. Thanks,

-- Steve