Re: [PATCH] mtd: flashchip: explicitly include <linux/wait.h>

[Miquel Raynal]

On Mon, 2024-02-05 at 10:09:55 UTC, Tudor Ambarus wrote:
> While reviewing the hyperbus sfdp proposal the following problem was
> noticed:
> 
> In file included from ./include/linux/mtd/gen_probe.h:10,
>                  from drivers/mtd/hyperbus/hyperbus-sfdp.c:6:
> ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’
>    77 |         wait_queue_head_t wq; /* Wait on here when we're waiting for the chip
>       |         ^~~~~~~~~~~~~~~~~
> 
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
> 
> Explicitly include <linux/wait.h> in include/linux/mtd/flashchip.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel