Re: [PATCH 3/4] soc: samsung: exynos-chipid: add Google Tensor gs101 SoC support

From: Peter Griffin
Date: Mon Feb 05 2024 - 09:55:48 EST


On Thu, 1 Feb 2024 at 17:22, Alexey Klimov <alexey.klimov@xxxxxxxxxx> wrote:
>
> Add GS101 information to soc_ids table and related entries to other
> places. This SoC product id is "0x09845000".
>
> Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
> ---

Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>



> drivers/soc/samsung/exynos-chipid.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
> index b1118d37779e..7fee6094db12 100644
> --- a/drivers/soc/samsung/exynos-chipid.c
> +++ b/drivers/soc/samsung/exynos-chipid.c
> @@ -60,6 +60,8 @@ static const struct exynos_soc_id {
> { "EXYNOS850", 0xE3830000 },
> { "EXYNOSAUTOV9", 0xAAA80000 },
> { "EXYNOSAUTOV920", 0x0A920000 },
> + /* Compatible with: google,gs101-chipid */
> + { "GS101", 0x09845000 },
> };
>
> static const char *product_id_to_soc_id(unsigned int product_id)
> @@ -178,8 +180,17 @@ static const struct exynos_chipid_variant exynos850_chipid_drv_data = {
> .sub_rev_shift = 16,
> };
>
> +static const struct exynos_chipid_variant gs101_chipid_drv_data = {
> + .rev_reg = 0x10,
> + .main_rev_shift = 0,
> + .sub_rev_shift = 16,
> +};
> +
> static const struct of_device_id exynos_chipid_of_device_ids[] = {
> {
> + .compatible = "google,gs101-chipid",
> + .data = &gs101_chipid_drv_data,
> + }, {
> .compatible = "samsung,exynos4210-chipid",
> .data = &exynos4210_chipid_drv_data,
> }, {
> --
> 2.43.0
>