Re: [PATCH v4 01/16] spi: s3c64xx: explicitly include <linux/io.h>

From: Peter Griffin
Date: Mon Feb 05 2024 - 10:25:55 EST


On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
>
> The driver uses readl() but does not include <linux/io.h>.
>
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
>
> Include the missing header.
>
> Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---

Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>