Re: [PATCH v4 02/16] spi: s3c64xx: explicitly include <linux/bits.h>

From: Peter Griffin
Date: Mon Feb 05 2024 - 10:26:11 EST


On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
>
> The driver uses GENMASK() but does not include <linux/bits.h>.
>
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
>
> Include the missing header.
>
> Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---

Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>