Re: [PATCH-wq v3 0/4] workqueue: Enable unbound cpumask update on ordered workqueues

From: Waiman Long
Date: Mon Feb 05 2024 - 20:24:21 EST



On 2/5/24 19:04, Tejun Heo wrote:
On Mon, Feb 05, 2024 at 09:53:09AM -1000, Tejun Heo wrote:
On Mon, Feb 05, 2024 at 02:45:58PM -0500, Waiman Long wrote:
v3:
- [v2] https://lore.kernel.org/lkml/20240203154334.791910-1-longman@xxxxxxxxxx/
- Drop patch 1 as it has been merged into the for-6.9 branch.
- Use rcu_access_pointer() to access wq->dfl_pwq.
- Use RCU protection instead of acquiring wq->mutex in
apply_wqattrs_cleanup().
Looks like we raced each other. I'll wait for v4.
BTW, please don't bother to handle __WQ_ORDERED being cleared. We are very
close to removing the implicit ORDERED promotion, so we should be able to
apply the patch to remove the distinction between explicitly and implicitly
ordered workqueues.

BTW, the workqueue.c file in your latest for-6.9 branch still has a reference to __WQ_ORDERED_EXPLICIT in workqueue_apply_unbound_cpumask(). Will that break compilation?

Regards,
Longman